From dafbb594637a409803d92ecc30ef23867715e525 Mon Sep 17 00:00:00 2001 From: Julia McGhee Date: Fri, 20 Mar 2026 19:48:00 +0000 Subject: [PATCH] Fix Docker builds: drop frozen-lockfile for standalone app builds Apps build in isolation from the monorepo, so the root pnpm-lock.yaml doesn't match the app-level package.json. Use plain pnpm install since each app's package.json is the source of truth. --- .github/workflows/deploy-production.yaml | 2 -- apps/api/Dockerfile | 4 ++-- apps/web/Dockerfile | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/deploy-production.yaml b/.github/workflows/deploy-production.yaml index 959a7ce..da867ec 100644 --- a/.github/workflows/deploy-production.yaml +++ b/.github/workflows/deploy-production.yaml @@ -36,12 +36,10 @@ jobs: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin IFS=',' read -ra APPS <<< "${{ steps.changes.outputs.apps }}" for app in "${APPS[@]}"; do - cp pnpm-lock.yaml apps/${app}/pnpm-lock.yaml docker build \ -t ghcr.io/${{ github.repository_owner }}/homelab-${app}:${{ github.sha }} \ -t ghcr.io/${{ github.repository_owner }}/homelab-${app}:latest \ apps/${app} - rm apps/${app}/pnpm-lock.yaml docker push ghcr.io/${{ github.repository_owner }}/homelab-${app}:${{ github.sha }} docker push ghcr.io/${{ github.repository_owner }}/homelab-${app}:latest done diff --git a/apps/api/Dockerfile b/apps/api/Dockerfile index 01dd6a9..504a4de 100644 --- a/apps/api/Dockerfile +++ b/apps/api/Dockerfile @@ -2,8 +2,8 @@ FROM node:20-alpine AS base FROM base AS deps WORKDIR /app -COPY package.json pnpm-lock.yaml* ./ -RUN corepack enable pnpm && pnpm install --frozen-lockfile +COPY package.json ./ +RUN corepack enable pnpm && pnpm install FROM base AS builder WORKDIR /app diff --git a/apps/web/Dockerfile b/apps/web/Dockerfile index ff948b0..7fb22b9 100644 --- a/apps/web/Dockerfile +++ b/apps/web/Dockerfile @@ -3,8 +3,8 @@ FROM node:20-alpine AS base FROM base AS deps RUN apk add --no-cache libc6-compat WORKDIR /app -COPY package.json pnpm-lock.yaml* ./ -RUN corepack enable pnpm && pnpm install --frozen-lockfile +COPY package.json ./ +RUN corepack enable pnpm && pnpm install FROM base AS builder WORKDIR /app